Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • F firmware
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 74
    • Issues 74
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • card10card10
  • firmware
  • Merge requests
  • !354

fix(py display): remove unnecessary out-of-bounds checks to allow clipping of draw calls

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged fuchsi* requested to merge fuchsi/firmware:drawcall_clipping into master Nov 10, 2019
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

this solution is contrary to !74 (closed) . Closes #53 (closed) and #188 (closed) . Removing these checks in pycardium is fine as gfx_setpixel handles out-of-bounds coordinates just fine, so that (in accordance with the documentation) draw calls are clipped rather than throwing ValueErrors.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: drawcall_clipping