Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • F firmware
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 74
    • Issues 74
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • card10card10
  • firmware
  • Issues
  • #50
Closed
Open
Issue created Jul 19, 2019 by Rahix@rahixOwner

Timer in vibra-module is overwritten in some cases

When doing multiple calls to epic_vibra_vibrate in quick succession, one call might overwrite (by recreating) the timer from the previous call. Testing did not show issues so far, but it might mess with FreeRTOS' internal timer facilities.

Relevant line: vibra.c#L30

It would be better to initialize the timer once and then use xTimerChangePeriod to schedule it. While at it, it might also make sense to convert the timer to a static one by using xTimerCreateStatic instead of xTimerCreate.

Assignee
Assign to
Time tracking