Commit d189f48e authored by fuchsi*'s avatar fuchsi* Committed by Ben Huber
Browse files

fix(bhi, leds): fixed faulty error handling due to always-false unsigned comparisons

parent 87bccda8
...@@ -131,7 +131,7 @@ int epic_bhi160_enable_sensor( ...@@ -131,7 +131,7 @@ int epic_bhi160_enable_sensor(
int result = 0; int result = 0;
bhy_virtual_sensor_t vs_id = bhi160_lookup_vs_id(sensor_type); bhy_virtual_sensor_t vs_id = bhi160_lookup_vs_id(sensor_type);
if (vs_id < 0) { if (vs_id == (bhy_virtual_sensor_t)-1) {
return -ENODEV; return -ENODEV;
} }
...@@ -188,7 +188,7 @@ int epic_bhi160_disable_sensor(enum bhi160_sensor_type sensor_type) ...@@ -188,7 +188,7 @@ int epic_bhi160_disable_sensor(enum bhi160_sensor_type sensor_type)
int result = 0; int result = 0;
bhy_virtual_sensor_t vs_id = bhi160_lookup_vs_id(sensor_type); bhy_virtual_sensor_t vs_id = bhi160_lookup_vs_id(sensor_type);
if (vs_id < 0) { if (vs_id == (bhy_virtual_sensor_t)-1) {
return -ENODEV; return -ENODEV;
} }
......
...@@ -202,8 +202,8 @@ static MP_DEFINE_CONST_FUN_OBJ_2(leds_set_rocket_obj, mp_leds_set_rocket); ...@@ -202,8 +202,8 @@ static MP_DEFINE_CONST_FUN_OBJ_2(leds_set_rocket_obj, mp_leds_set_rocket);
static mp_obj_t mp_leds_get_rocket(mp_obj_t led_in) static mp_obj_t mp_leds_get_rocket(mp_obj_t led_in)
{ {
int led = mp_obj_get_int(led_in); int led = mp_obj_get_int(led_in);
uint8_t ret = epic_leds_get_rocket(led); int ret = epic_leds_get_rocket(led);
if (ret == -EINVAL) { if (ret == -EINVAL) {
mp_raise_ValueError( mp_raise_ValueError(
"invalid value: maybe the led does not exists" "invalid value: maybe the led does not exists"
......
...@@ -112,7 +112,7 @@ void epic_isr_ctrl_c(void) ...@@ -112,7 +112,7 @@ void epic_isr_ctrl_c(void)
void mp_hal_set_interrupt_char(char c) void mp_hal_set_interrupt_char(char c)
{ {
if (c != -1) { if (c != '\xFF') {
mp_obj_exception_clear_traceback( mp_obj_exception_clear_traceback(
MP_OBJ_FROM_PTR(&MP_STATE_VM(mp_kbd_exception)) MP_OBJ_FROM_PTR(&MP_STATE_VM(mp_kbd_exception))
); );
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment