variable is subsequently not used

Change-Id: I177d21c6ba9f1f2e3765feffdbf317ea375a8cfe
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/149


Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>

Update devices as per the latest programming manual.

We now use the full DEVID to identify the target. Previously we used
a 8bit id but that has now been changed in the manual.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>

Do not require unecessary roundtrips for clocking out
data.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

Do not propagate error number to user. This is for internal
programming purposes only. Error messages to the user is
reported as text via LOG_ERROR().

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>

 - add comment where to find the various loaders src files.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>

For the above targets the exit_point is
optional when used with run_algorithm, so remove it.

This makes updating the algorithm less error prone.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>

Fix similar memory leaks as per commit:
ef72484b



Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>

Final target is to force bus_width size during CFI flash
read.
In this first step I need to replace default flash read
with flash specific implementation.
This patch introduces:
- flash_driver_read() layer;
- default_flash_read(), backward compatible;
- read() callback in struct flash_driver;
- proper initialization in every flash_driver instance.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>

Removed bogus errors when trying to allocate a large
a target memory buffer as possible.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

'unlock' performs a full unlock/erase of the device, removing any
code protection.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>

Add flash algorithm support for the PIC32MX.
Still a few things todo but this dramatically decreases
the programing time, eg. approx programming for 2.5k test file.
 - without fastload: 60secs
 - with fastload: 45secs
 - with fastload and algorithm: 2secs.

Add new devices to supported list.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>

Fix goofy struct indents.  Function names *are* their addresses.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

The flash.h header does not require the target.h header file, but
its implementation source files do.  Move it to flash/nor/imp.h.

Changes from the flat namespace to heirarchical one.  Instead of writing:

	#include "mips32.h"

the following form should be used.

	#include <target/mips32.h>

The exception is from .c files in the same directory.

Moves NOR flash drivers to 'src/flash/nor/'.
Adds 'src/flash/nor/Makefile.am'.
Builds 'libocdflashnor.la'.

Replace flash_driver callback with pointer to command_registration.
Eliminates all related routines and allows drivers to omit commands.

Replaces direct calls to register_command() with a macro, to allow
its parameters to be changed and callers updated in phases.

After adding support for referencing banks by name, renames
the COMMAND_HELPERs appropriately:
flash_command_get_bank_by_num  -> flash_command_get_bank
nand_command_get_device_by_num -> flash_command_get_device

Convert all command handler 'cmd_ctx' parameter usage with CMD_CTX.

This patch converts all instances of 'args' in COMMAND_HANDLER routines
to use CMD_ARGV macro.

This patch converts all instances of 'argc' in COMMAND_HANDLER routines
to use CMD_ARGC.

Use COMMAND_HELPER macro to declare flash_command_get_bank_by_num.
This is required for COMMAND_PARSE_NUMBER macro.

Remove misleading typedef and redundant suffix from struct command.

Remove misleading typedef and redundant suffix from struct command_context.

Remove misleading typedef and redundant suffix from struct flash_bank.

Remove misleading typedef and redundant suffix from struct target.

Remove misleading typedef and redundant suffix from struct working_area.

Remove misleading typedef and redundant suffix from struct mips_ejtag.

Remove misleading typedef and redundant suffix from struct mips32_common.

Remove misleading typedef and redundant suffix from struct armv7m_algorithm.

Remove misleading typedef and redundant suffix from struct pic32mx_flash_bank.

Remove misleading typedef and redundant suffix from struct flash_driver.

Remove misleading typedef and redundant suffix from struct flash_sector.

Defines all flash_bank_command handlers using the new macro.