Replaces direct calls to register_command() with a macro, to allow
its parameters to be changed and callers updated in phases.

4096 byte buffer allocated dynamically. Better
for embedded OS's.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

Create a generic register_cache_invalidate(), and use it to
replace three all-but-identical core-specific routines:

 - armv4_5_invalidate_core_regs()
 - armv7m_invalidate_core_regs
 - mips32_invalidate_core_regs() too.

Make cache->num_regs be unsigned, avoiding various errors.

Net code shrink and simplification.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Updates all command parsing of "on" and "off" arguments.

The recent migration broke them, the fixes broken them in a new way,
but this should restore them to working order.  Eliminates the
temporary variable, as the CMD_NAME macro can once again be use
in routines that increment CMD_ARGV without nasty side-effects.

Convert all command handler 'cmd_ctx' parameter usage with CMD_CTX.

This patch converts all instances of 'args' in COMMAND_HANDLER routines
to use CMD_ARGV macro.

This patch converts all instances of 'argc' in COMMAND_HANDLER routines
to use CMD_ARGC.

No need to indirect from registered integers to pointers.
Just stash the pointers directly in the register struct,
and don't even bother registering.

This is a small code shrink, speeds register access just
a smidgeon, and gets rid of another rude exit() path.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Use size_t instead of uint32_t when specifying file sizes.  Update all
consumers up through the layers to use size_t when required.  These
changes should be safe, but the higher-levels will need to be updated
further to receive the intended benefits (i.e. large file support).

Add error checking for fileio_read and file_write.  Previously, all
errors were being silently ignored, so this change might cause some
problems for some people in some cases.  However, it gives us the chance
to handle any errors that do occur at higher-levels, rather than burying
our heads in the sand.

Add const keyword to file url and cast to free().

Make size an ssize_t and chase all format strings that use it.

Improves the name of this macro, moves it to types.h, and adds a block
of Doxygen comments to describe what it does.

Most files in the tree seem to have ended up including this,
and *quite* needlessly ... only code implementing or using
breakpoints actually needs these declarations.

So take it out of the header files which included it, and put
it in files which use it ... reduce needless interdependencies.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Previously this flag was stored in "target_type", so that for example
if there were two ARM7TDMI targets in a scan chain, both would claim
to have been examined although only the first one actually had its
examine() method called.

Move this state to where it should have been in the first place, and
hide a method that didn't need exposure ... the flag is write-once.

Provide some doxygen.  The examine() method is confusing, since it
isn't separating one-time setup from the after-each-reset stuff.  And
the ARM7/ARM9 version is, somewhat undesirably, not leaving the debug
state alone after reset ... probably more of an issue for trace setup
than for watchpoints and breakpoints.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

This fixes an issue due to the new command handler syntax caused by the mw handler playing with the args pointer before
using the CMD_NAME macro.  Fix is to move this call above the lines changing args.

Changed some printf format strings..

[dbrownell@users.sourceforge.net: shrink lines, fix indents]

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Remove misleading typedef and redundant suffix from struct command_context.

Remove misleading typedef and redundant suffix from struct target.

Remove misleading typedef and redundant suffix from struct reg.

Remove misleading typedef and redundant suffix from struct target_type.

Remove misleading typedef and redundant suffix from struct image.

Also removes the typedef from enum image_type, as it is used in
image.h only.

Remove misleading typedef and redundant suffix from struct trace.

Remove misleading typedef and redundant suffix from struct breakpoint.

Remove misleading typedef and redundant suffix from struct target_event_action.

Remove misleading typedef and redundant suffix from struct target_timer_callback.

Remove misleading typedef and redundant suffix from struct target_event_callback.

Remove misleading typedef and redundant suffix from struct working_area.

Remove misleading typedef and redundant suffix from struct reg_arch_type.

Remove misleading typedef and redundant suffix from struct reg_cache.

Remove misleading typedef and redundant suffix from struct watchpoint.

Remove misleading typedef and redundant suffix from struct reg_param.

Remove misleading typedef and redundant suffix from struct mem_param.

Search and destroy the jtag_tap_t typedef.  This also cleans up a
layering violation, removing the declaration from types.h.

Remove useless structure typedef.

By introducing the CMD_NAME macro, this parameter may be integrated
as args[-1] in command.[ch], without touching any other call sites.

By using CALL_COMMAND_HANDLER, parameters can be reordered, added, or
even removed in inherited signatures, without requiring revisiting
all of the various call sites.

Define the numerous helpers that inherit command handler parameters
using the COMMAND_HELPER macro.

Add 'const' keyword to 'char *' parameters to allow command handlers to
pass constant string arguments.  These changes allow the 'args' command
handler to be changed to 'const' in a subsequent patch.