- 13 Nov, 2009 7 commits
-
-
Zachary T Welch authored
Remove misleading typedef and redundant suffix from struct mem_param.
-
Zachary T Welch authored
Search and destroy the jtag_tap_t typedef. This also cleans up a layering violation, removing the declaration from types.h.
-
Zachary T Welch authored
Remove useless structure typedef.
-
Zachary T Welch authored
By introducing the CMD_NAME macro, this parameter may be integrated as args[-1] in command.[ch], without touching any other call sites.
-
Zachary T Welch authored
By using CALL_COMMAND_HANDLER, parameters can be reordered, added, or even removed in inherited signatures, without requiring revisiting all of the various call sites.
-
Zachary T Welch authored
Define the numerous helpers that inherit command handler parameters using the COMMAND_HELPER macro.
-
Zachary T Welch authored
-
- 11 Nov, 2009 1 commit
-
-
Zachary T Welch authored
Add 'const' keyword to 'char *' parameters to allow command handlers to pass constant string arguments. These changes allow the 'args' command handler to be changed to 'const' in a subsequent patch.
-
- 10 Nov, 2009 4 commits
-
-
David Brownell authored
Start switching MMU handling over to a more sensible scheme. Having an mmu() method enables MMU-aware behaviors. Not having one kicks in simpler ones, with no distinction between virtual and physical addresses. Currently only a handful of targets have methods to read/write physical memory: just arm720, arm920, and arm926. They should all initialize OK now, but the arm*20 parts don't do the "extra" stuff arm926 does (which should arguably be target-generic). Also simplify how target_init() loops over all targets by making it be a normal "for" loop, instead of scattering its three parts to the four winds. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
- improve some names -- a "default" prefix is not descriptive - add doxygen @todo entries for some issues - avr8 isn't ever going to need those MMU hooks Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
And shrink a few too-long lines. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
Zachary T Welch authored
This patch removes the last batch of forward references from the tree, moving the target command registration routines to the end of the file.
-
- 09 Nov, 2009 3 commits
-
-
David Brownell authored
This patch introduced a bug preventing flash writes from working on Cortex-M3 targets like the STM32. Moreover, it's the wrong approach for handling no-MMU targets. The right way to handle no-MMU targets is to provide accessors for physical addresses, and use them everywhere; and any code which tries to work with virtual-to-physical mappings should use a identity mapping (which can be defaulted). And ... we can tell if a target has an MMU by seeing if it's got an mmu() method. No such methood means no MMU. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
It's been about a year since these were deprecated and, in most cases, removed. There's no point in carrying that documentation, or backwards compatibility for "jtag_device" and "jtag_speed", around forever. (Or a few remnants of obsolete code...) Removed a few obsolete uses of "jtag_speed": - The Calao stuff hasn't worked since July 2008. (Those Atmel targets need to work with a 32KHz core clock after reset until board-specific init-reset code sets up the PLL and enables a faster JTAg clock.) - Parport speed controls don't actually work (tops out at about 1 MHz on typical HW). - In general, speed controls need to live in board.cfg files (or sometimes target.cfg files), not interface.cfg ... Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
Zachary T Welch authored
This patch changes the duration_* API in several ways. First, it updates the API to use better names. Second, string formatting has been removed from the API (with its associated malloc). Finally, a new function added to convert the time into seconds, which can be used (or formatted) by the caller. This eliminates hidden calls to malloc that require associated calls to free(). This patch also removes the useless extern keyword from prototypes, and it eliminates the duration_t typedef (use 'struct duration'). These API also allows proper error checking, as it is possible for gettimeofday to fail in certain circumstances. The consumers have all been chased to use this new API as well, as there were relatively few cases doing this type of measurement. In most cases, the code performs additional checks for errors, but the calling code looks much cleaner in every case.
-
- 06 Nov, 2009 2 commits
-
-
David Brownell authored
Resolve serious bug inserted by the "target: require working area for physical/virtual addresses to be specified" patch. It forced use of (invalid) virtual addresses when the MMU was disabled, and vice versa. Observed to break at least Cortex-M3, ARM926, ARM7TDMI whenever work areas are used, such as during bulk writes to flash, DDR2, SRAM, and so on. Also, fix overlong lines and whitespace goofs. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
Zachary T Welch authored
Passes cmd_ctx into parse_load_image_command_args for reporting the parsing errors therein.
-
- 05 Nov, 2009 6 commits
-
-
Øyvind Harboe authored
Now matches machine code syntax and old arm11 syntax. Signed-off-by:
Øyvind Harboe <oyvind.harboe@zylin.com>
-
Øyvind Harboe authored
Signed-off-by:
Øyvind Harboe <oyvind.harboe@zylin.com>
-
Øyvind Harboe authored
This avoids polluting help for targets that can never support mrc/mcr Signed-off-by:
Øyvind Harboe <oyvind.harboe@zylin.com>
-
David Brownell authored
Fail watchpoint_add() if it's the same address but the parameters are different ... don't just assume having the same address means the same watchpoint! (Note that overlapping watchpoints aren't detected...) Handle unrecognized return codes more sanely; don't exit()! And describe command params right. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
Øyvind Harboe authored
improve default target->read/write_phys_memory, produce more sensible error messages if the mmu interface functions have not been implemented yet vs. will not be implemented(e.g. cortex m3). Signed-off-by:
Øyvind Harboe <oyvind.harboe@zylin.com>
-
Øyvind Harboe authored
-
- 03 Nov, 2009 1 commit
-
-
Øyvind Harboe authored
Fixed bug: if virtual address for working memory was not specified and MMU was enabled, then address 0 would be used. Require working address to be specified for both MMU enabled and disabled case. For some completely inexplicable reason this fixes the regression in svn 2646 for flash write in arm926ejs target. The logs showed that MMU was disabled in the case below: https://lists.berlios.de/pipermail/openocd-development/2009-November/011882.html Signed-off-by:
Øyvind Harboe <oyvind.harboe@zylin.com>
-
- 23 Oct, 2009 2 commits
-
-
Øyvind Harboe authored
-
Øyvind Harboe authored
-
- 22 Oct, 2009 1 commit
-
-
David Brownell authored
When dumping over 100 registers (as on most ARM9 + ETM cores), aid readability by splitting them into logical groups. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
- 21 Oct, 2009 1 commit
-
-
Øyvind Harboe authored
Added target_read/write_phys_memory() fn's. mdX/mwX commands updated to support phys flag to specify bypassing of MMU.
-
- 13 Oct, 2009 2 commits
-
-
Yauheni Kaliuta authored
Signed-off-by:
Yauheni Kaliuta <y.kaliuta@gmail.com>
-
Øyvind Harboe authored
-
- 12 Oct, 2009 1 commit
-
-
Øyvind Harboe authored
-
- 08 Oct, 2009 2 commits
-
-
David Brownell authored
Observed: openocd: core.c:318: jtag_checks: Assertion `jtag_trst == 0' failed. The issue was that nothing disabled background polling during calls from the TCL shell to "jtag_reset 1 1". Fix by moving the existing poll-disable mechanism to the JTAG layer where it belongs, and then augmenting it to always pay attention to TRST and SRST. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
Øyvind Harboe authored
-
- 21 Sep, 2009 1 commit
-
-
dbrownell authored
files; omitted src/httpd git-svn-id: svn://svn.berlios.de/openocd/trunk@2742 b42882b7-edfa-0310-969c-e2dbd0fdcd60
-
- 20 Sep, 2009 1 commit
-
-
dbrownell authored
- Shrink messaging during resets, primarily by getting rid of "nothing happened" noise that hides *useful* information. - Improve: the "no IDCODE" message by identifying which tap only supports BYPASS; and the TAP event strings. Related minor code updates: - Remove two needless tests when examining the chain: we know we have a TAP, and that all TAPs have names. - Clean up two loops, turning "while"s into "for"s which better show what's actually being done. git-svn-id: svn://svn.berlios.de/openocd/trunk@2736 b42882b7-edfa-0310-969c-e2dbd0fdcd60
-
- 19 Sep, 2009 1 commit
-
-
dbrownell authored
and Tcl/external): - Reorder so *both* paths (TCK/TMS or TRST) can enable TAPs with ICEpick ... first C code flags TAPs that got disabled, then call any Tcl code that might want to re-enable them. - Always call the C/internal handlers when JTAG operations can be issued; previously that wasn't done when TRST was used. Plus some small cleanups (whitespace, strings, better messaging during debug and on some errors) to reset-related code. git-svn-id: svn://svn.berlios.de/openocd/trunk@2730 b42882b7-edfa-0310-969c-e2dbd0fdcd60
-
- 11 Sep, 2009 3 commits
-
-
oharboe authored
git-svn-id: svn://svn.berlios.de/openocd/trunk@2693 b42882b7-edfa-0310-969c-e2dbd0fdcd60
-
oharboe authored
git-svn-id: svn://svn.berlios.de/openocd/trunk@2692 b42882b7-edfa-0310-969c-e2dbd0fdcd60
-
oharboe authored
git-svn-id: svn://svn.berlios.de/openocd/trunk@2690 b42882b7-edfa-0310-969c-e2dbd0fdcd60
-
- 10 Sep, 2009 1 commit
-
-
oharboe authored
Alexei Babich <a.babich@rez.ru> fix problems with unecessary tailend byte accesses. Use 16 bit access on tailend of a memory read if possible. git-svn-id: svn://svn.berlios.de/openocd/trunk@2684 b42882b7-edfa-0310-969c-e2dbd0fdcd60
-