1. 07 Apr, 2019 1 commit
  2. 27 Mar, 2019 1 commit
  3. 12 Mar, 2019 1 commit
  4. 08 Mar, 2019 1 commit
  5. 26 Nov, 2018 1 commit
  6. 01 Aug, 2018 1 commit
  7. 18 Jul, 2018 1 commit
  8. 10 Apr, 2018 1 commit
    • Tomas Vanek's avatar
      flash/nor: handle flash write alignment/padding in the infrastructure · c8c20b7c
      Tomas Vanek authored
      
      
      Most of flash drivers have to ensure proper flash write block alignment
      and padding. As there was no support for it in the flash infrastructure,
      each driver does it its own way. Sometimes this part of code is not properly
      tested and contains bugs.
      
      flash_write(_unlock) joins all image sections targeted to one flash bank
      using padded areas as a glue. This solves alignment problems on section
      boundaries but imposes other problems.
      
      Introduce new flash bank parameters write_start_alignment,
      write_end_alignment and minimal_write_gap.
      New flash drivers can just properly set these values instead of handling
      alignment by its own.
      
      Adapt infrastructure (namely flash_write_unlock(), handle_flash_fill_command()
      and handle_flash_write_bank_command()) to prepare write data padded
      to an alignment required by the flash bank.
      
      Rework flash_write_unlock() to discontinue write block when the gap
      between sections is bigger than minimum specified in minimal_write_gap.
      minimal_write_gap is set to one sector by default.
      
      Change-Id: I4368dd402dfaf51c193bcbf1332cffff092b239b
      Signed-off-by: default avatarTomas Vanek <vanekt@fbl.cz>
      Reviewed-on: http://openocd.zylin.com/4399
      
      
      Tested-by: jenkins
      Reviewed-by: default avatarAndreas Bolsch <hyphen0break@gmail.com>
      c8c20b7c
  9. 17 Jun, 2017 4 commits
  10. 24 Apr, 2017 2 commits
  11. 15 Jan, 2017 1 commit
  12. 04 Nov, 2016 1 commit
    • HarishKumar's avatar
      Tcl commands: Fix improper return status in flash commands and load_image. · b10037a0
      HarishKumar authored
      
      
      Nand write command :
      nand_fileio_cleanup() always returns ERROR_OK. Due to this,
      handle_nand_write_command() retuns ERROR_OK in the case
      of nand failure. ERROR_FAIL should be returned.
      
      Flash erase_sector command :
      handle_flash_erase_command() always returns ERROR_OK even if
      the erase functionality of actual driver implementation fails.
      retval value should be returned.
      
      Flash write_bank command :
      handle_flash_write_bank_command() returns ERROR_OK even if
      fileio_open() and fileio_read fails. ERROR_FAIL should be
      returned.
      
      Load_image command :
      handle_load_image_command() retuns ERROR_OK even if image_open()
      fails. ERROR_FAIL should be returned.
      When the buffer is null, breaking the loop without setting
      retval = ERROR_FAIL would cause load_image to return ERROR_OK.
      
      Change-Id: Ice32f6036971ab5e8e4dd65edf54b394b001c80c
      Signed-off-by: default avatarHarishKumar <harishpresent@gmail.com>
      Reviewed-on: http://openocd.zylin.com/2431
      
      Reviewed-by: default avatarAndreas Fritiofson <andreas.fritiofson@gmail.com>
      Tested-by: jenkins
      b10037a0
  13. 30 Oct, 2016 1 commit
    • Andreas Färber's avatar
      flash/nor: Add erased_value to drivers and pass it to targets · eaacb900
      Andreas Färber authored
      
      
      struct flash_driver has a default_padded_value field that is similar,
      but it can be changed by the user for the specific purpose of padding.
      
      Add a new erased_value field and initialize it for all targets,
      particularly stm32lx, xmc4xxx and virtual.
      
      Use this value in core.c:default_flash_mem_blank_check(), the slow path.
      
      Extend the target API to pass erased_value down to target code.
      Adding an argument ensures that we catch all callers.
      
      This allows us to merge xmc4xxx.c:xmc4xxx_blank_check_memory() into
      armv7m:armv7m_blank_check_memory().
      
      It further allows us to use default_flash_blank_check() in place of
      xmc4xxx.c:xmc4xxx_flash_blank_check(), adding a potential slow path
      fallback, as well as stm32lx:stm32lx_erase_check(), adding the potential
      armv7m fast path with fallback to default_flash_mem_blank_check().
      
      Fix a mips32 code comment while at it (zeroed -> erased).
      
      The armv4_5 and mips32 target implementations will now error out if an
      erase value other than 0xff is used, causing default_flash_blank_check()
      to fall back to the default_flank_mem_blank_check() slow path.
      
      Change-Id: I39323fbbc4b71c256cd567e439896d0245d4745f
      Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
      Reviewed-on: http://openocd.zylin.com/3497
      
      
      Tested-by: jenkins
      Reviewed-by: default avatarTomas Vanek <vanekt@fbl.cz>
      eaacb900
  14. 14 Aug, 2016 1 commit
  15. 13 Aug, 2016 1 commit
  16. 24 May, 2016 1 commit
  17. 29 Feb, 2016 1 commit
  18. 03 Nov, 2015 1 commit
  19. 06 Aug, 2015 1 commit
  20. 22 Sep, 2014 1 commit
  21. 22 Jun, 2014 1 commit
  22. 29 Mar, 2014 1 commit
  23. 31 Oct, 2013 1 commit
  24. 07 Oct, 2013 1 commit
  25. 03 Oct, 2013 1 commit
  26. 05 Jun, 2013 1 commit
  27. 24 Aug, 2012 1 commit
  28. 06 Feb, 2012 1 commit
  29. 23 Jan, 2012 1 commit
  30. 04 Jan, 2012 1 commit
  31. 09 Aug, 2011 1 commit
  32. 03 Jan, 2011 1 commit
  33. 23 Dec, 2010 1 commit
  34. 29 Sep, 2010 2 commits
  35. 21 Sep, 2010 1 commit