- 07 Apr, 2019 12 commits
-
-
Antonio Borneo authored
Change-Id: I4a8a68147011525191ca79e65fc3d7e760371ae1 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5020 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Antonio Borneo authored
The notation "(tck tms tdi tdo)* " is incorrect, because it means the quadruple of gpio can be repeated on the command-line. The correct syntax of the command requires instead to provide either all the four gpio numbers (in order to set the values) or to pass an empty command-line (to dump the values previously set). Change the .usage field to "[tck tms tdi tdo]". Change similarly the corresponding .usage field for SWD command. Add the .usage field for the commands that individually set each gpio or gpio property. Dump the previously set values when commands bcm2835gpio_speed_coeffs or bcm2835gpio_peripheral_base are executed with empty command-line. Change-Id: Ie45d8268c1de331aded0bb52d5e6b8f0e8766a5b Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5019Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
-
Antonio Borneo authored
The notation "(tck tms tdi tdo)* " is incorrect, because it means the quadruple of gpio can be repeated on the command-line. The correct syntax of the command requires instead to provide either all the four gpio numbers (in order to set the values) or to pass an empty command-line (to dump the values previously set). Change the .usage field to "[tck tms tdi tdo]". Change similarly the corresponding .usage field for SWD command. Add the .usage field for the commands that individually set each gpio or gpio property. Dump the previously set values when commands imx_gpio_speed_coeffs or imx_gpio_peripheral_base are executed with empty command-line. Change-Id: Id56a68622817101bd0a46fed1fead6d2cd2b6ec6 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5018 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Antonio Borneo authored
Chained command require a subcommand as first argument. The usage field for chained commands is not really important because the "help" command will list all the subcommands with their respective usage. Add a empty usage field on all chained command. The command "jlink config" can be either followed by a subcommand or used alone, so use a dedicated usage string. Change-Id: I43c3f8a766f96a9bdab4e709e3c90713be41fcef Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5017 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Antonio Borneo authored
There is no need to split the string in two lines. Change-Id: Ifc574904acd06c31fab589643334e86f4dd0a122 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5016 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Antonio Borneo authored
Keep using the same indentation rules while initializing struct command_registration. Change-Id: I900924600753ee7a72ca45da13db4112ab4b1522 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5015Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
-
Antonio Borneo authored
Keep using the same indentation rules while initializing struct command_registration. Change-Id: Ie69d9d6a786e1ef0abbcfd3eef89a61206238ebe Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5014Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
-
Antonio Borneo authored
While initializing struct command_registration, the field's name "name" is not specified, thus relying on the fact that it is the first field declared in the struct and it's initialization value can be listed as the first one. Be coherent in the struct initialization and always use the field's name. Change-Id: Iefaeb15cc051db9f1e0f0140fe2f231b45f5bb12 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5013Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins Reviewed-by:
Tim Newsome <tim@sifive.com>
-
Antonio Borneo authored
While initializing struct command_registration, the field's name "name" is not specified, thus relying on the fact that it is the first field declared in the struct and it's initialization value can be listed as the first one. Be coherent in the struct initialization and always use the field's name. Change-Id: I65d32870bf4d3df845db69682fe445c71642f976 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5012Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
-
Antonio Borneo authored
While initializing struct command_registration, the field's name "name" is not specified, thus relying on the fact that it is the first field declared in the struct and it's initialization value can be listed as the first one. Be coherent in the struct initialization and always use the field's name. Change-Id: I9ef7ac08e7cd5b82a6a7896c47017943d668925f Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5011Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
-
Antonio Borneo authored
While initializing struct command_registration, the field's name "name" is not specified, thus relying on the fact that it is the first field declared in the struct and it's initialization value can be listed as the first one. Be coherent in the struct initialization and always use the field's name. Change-Id: I743457acf7757df4646c9bc4e5ea1a6f9c841516 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5010Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
-
Antonio Borneo authored
The struct log_command_handlers[] is never modified. Add const qualifier to it. Change-Id: I5785aeb09ae9c23eaf7c34a05b88d0c7285f2d78 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5009Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
-
- 04 Apr, 2019 1 commit
-
-
Paul Fertser authored
mem2array returns a Tcl (associative) array and so the order of elements is not guaranteed. Treat it as such. Change-Id: Ie4d1219faac1e60247ca13bc2eedf22041a9a9e9 Signed-off-by:
Paul Fertser <fercerpav@gmail.com> Reviewed-on: http://openocd.zylin.com/4487 Tested-by: jenkins Reviewed-by:
Christopher Head <chead@zaber.com>
-
- 03 Apr, 2019 6 commits
-
-
Peter Lawrence authored
ctrl-z usage is incorrectly commented as ctrl-d Change-Id: I54fe1775760ee984154bbae380baa38bcaffa04e Signed-off-by:
Peter Lawrence <majbthrd@gmail.com> Reviewed-on: http://openocd.zylin.com/4863 Tested-by: jenkins Reviewed-by:
Christopher Head <chead@zaber.com> Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Mete Balci authored
Fixed the small typo. Change-Id: Ia8834b23302d25e92cb2fa0802bebb2a9416595b Signed-off-by:
Mete Balci <metebalci@gmail.com> Reviewed-on: http://openocd.zylin.com/5001 Tested-by: jenkins Reviewed-by:
Antonio Borneo <borneo.antonio@gmail.com>
-
Tomas Vanek authored
Setting of flash_sector::is_erased in flash erase and mass erase is popular folklore. Make clear it is useless. Change-Id: Ide397eb6d24fc8fa38931e6c8a0693d39668a5d2 Signed-off-by:
Tomas Vanek <vanekt@fbl.cz> Reviewed-on: http://openocd.zylin.com/4768 Tested-by: jenkins Reviewed-by:
Christopher Head <chead@zaber.com>
-
Antonio Borneo authored
The TCL command exit is already replaced by the OpenOCD command exit in server/telnet_server.c, no need to redefine it in the script. Moreover, the implementation is broken because the proc ocd_throw has been removed in mid 2008 with pre-git-era commit dfbb9f3e in svn rev 849. Remove completely the unused proc exit. Change-Id: I0365d740eccc47631eb459aab77b865b0877c1f7 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/4986 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Florian Fainelli authored
Depending on how the MMU is configured it is possible to have a 1:1 mapping between virtual and physical addresses, thus making this warning bogus. We already check that the MMU is enabled in the caller: cortex_a_virt2phys(). Change-Id: I09f4c53ef933c8d1e268da5215a769449be014bc Signed-off-by:
Florian Fainelli <f.fainelli@gmail.com> Reviewed-on: http://openocd.zylin.com/5007 Tested-by: jenkins Reviewed-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-by:
Kamal Dasu <kdasu.kdev@gmail.com> Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de>
-
Tomas Vanek authored
Remove the target halted check from cortex_m_remove_breakpoint() as there is no such check in cortex_m_set_breakpoint() and bp can be safely removed from the running target. While on it return the error code from cortex_m_unset_breakpoint() to higher level. Change-Id: I2b358c3661feed84297913e9f589bdf1e4de7e64 Signed-off-by:
Tomas Vanek <vanekt@fbl.cz> Reviewed-on: http://openocd.zylin.com/4887 Tested-by: jenkins Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de> Reviewed-by:
Jānis Skujenieks <janis.skujenieks@gmail.com> Reviewed-by:
Christopher Head <chead@zaber.com>
-
- 01 Apr, 2019 2 commits
-
-
Tomas Vanek authored
fp_code_available looses sync with the real number of free comparators as soon as cortex_m_set_breakpoint() returns an error. Remove the counter and always go through the fp_comparator_list to find a free one. Change-Id: I9f6e06c36d8a57ad11df5155e8a1a3aff6d833a5 Signed-off-by:
Tomas Vanek <vanekt@fbl.cz> Reviewed-on: http://openocd.zylin.com/4870 Tested-by: jenkins Reviewed-by:
Jānis Skujenieks <janis.skujenieks@gmail.com> Reviewed-by:
Christopher Head <chead@zaber.com> Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de>
-
Tomas Vanek authored
Cortex-M uses only 2 byte breakpoint instruction. cortex_m_unset_breakpoint() does not need to check breakpoint->length, use the length as the size argument in target_write_memory() Change-Id: I20bb869f6abce2fc61f0469e34a638bc4dc6f7ce Signed-off-by:
Tomas Vanek <vanekt@fbl.cz> Reviewed-on: http://openocd.zylin.com/4889 Tested-by: jenkins Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de> Reviewed-by:
Jānis Skujenieks <janis.skujenieks@gmail.com> Reviewed-by:
Christopher Head <chead@zaber.com>
-
- 27 Mar, 2019 6 commits
-
-
Christopher Head authored
Instances of struct flash_driver are never written to at runtime. For a small amount of memory saving and also robustness (fewer things for stray pointer writes to hit), mark them const. Change-Id: Iadbbbc2fac0976d892699200000c5f02856729f3 Signed-off-by:
Christopher Head <chead@zaber.com> Reviewed-on: http://openocd.zylin.com/4803Reviewed-by:
Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de>
-
Antonio Borneo authored
The code for this command is currently replicated in cortex_a and in mips_m4k and is going to be added again for cortex_m. Plus, it is going to be obsoleted by the HW thread pseudo RTOS. Consolidate in smp.c a single instance of the command. This will simplify both obsoleting it and adding it to cortex_m, whatever change comes first. Change-Id: I03cd857e21fa3f7202fdcee36bcbd5aae30a609d Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/4991 Tested-by: jenkins Reviewed-by:
Tarek BOCHKATI <tarek.bouchkati@gmail.com> Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de>
-
Antonio Borneo authored
Seams over-engineered having two separate commands to turn SMP on/off. Plus it is missing the possibility to dump the current status of SMP and would be weird adding an additional command for it. Moreover, such commands are replicated in few targets so it would make sense centralizing them. - Deprecate the commands "smp_on" and "smp_off". - Add a new command "smp" that accepts optional parameters "[on|off]" and prints the SMP status when run without parameters. This replaces the two commands above. - Put the deprecated and the new command handlers in smp.c - Update the documentation, except for mips_m4k, since it is not available yet. - Promote the macro foreach_smp_target to global context and use it where possible. Change-Id: Ia72841c1a3bd6edd4db4cc809046322f498617e6 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/4615 Tested-by: jenkins Reviewed-by:
Graham Sanderson <graham.sanderson@gmail.com> Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de>
-
Angus Ainslie authored
The imx8m also has a Cortex m4 so add a target for it. Change-Id: I2abf62b6232c547fe9b12507f459835b11c63a6d Signed-off-by:
Angus Ainslie <angus@akkea.ca> Reviewed-on: http://openocd.zylin.com/4501 Tested-by: jenkins Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de>
-
Tomas Vanek authored
Use target_addr_t exclusively for comparison of sector boudaries and address range. Use the last addres for both address range end and sector end. It avoids problems with a flash bank mapped at the very end of target address space. Change-Id: Idf97c837453d97cbc4cf8a1c76ad799f4142f19e Signed-off-by:
Tomas Vanek <vanekt@fbl.cz> Reviewed-on: http://openocd.zylin.com/4985 Tested-by: jenkins Reviewed-by:
Tim Newsome <tim@sifive.com> Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de>
-
Tim Newsome authored
This represents months of continuing RISC-V work, with too many changes to list individually. Some improvements: * Fixed memory leaks. * Better handling of dbus timeouts. * Add `riscv expose_custom` command. * Somewhat deal with cache coherency. * Deal with more timeouts during block memory accesses. * Basic debug compliance test. * Tell gdb which watchpoint hit. * SMP support for use with -rtos hwthread * Add `riscv set_ir` Change-Id: Ica507ee2a57eaf51b578ab1d9b7de71512fdf47f Signed-off-by:
Tim Newsome <tim@sifive.com> Reviewed-on: http://openocd.zylin.com/4922 Tested-by: jenkins Reviewed-by:
Philipp Guehring <pg@futureware.at> Reviewed-by:
Liviu Ionescu <ilg@livius.net> Reviewed-by:
Matthias Welwarsky <matthias@welwarsky.de>
-
- 26 Mar, 2019 1 commit
-
-
Frans-Willem Hardijzer authored
Some boards require a slower clock speed because of passive components on the JTAG/SWD lines. The previous implementation would first try to discover the chips on the default speed, and only after discovery switch to the requested adapter_khz speed. This patch moves the speed change to just before entering the SWD/JTAG mode, which should alleviate this problem. Tested on an STLink V2 clone. Change-Id: I9734452dcc8bb28d6629e64d9a7e32ef92868cf9 Signed-off-by:
Frans-Willem Hardijzer <fw@hardijzer.nl> Reviewed-on: http://openocd.zylin.com/4818 Tested-by: jenkins Reviewed-by:
Antonio Borneo <borneo.antonio@gmail.com>
-
- 23 Mar, 2019 2 commits
-
-
Marek Vasut authored
Fix indent of the macros in header file, no functional change. Change-Id: I4d1dba5725155200148d1543c45bad919f6cd37e Signed-off-by:
Marek Vasut <marek.vasut@gmail.com> Reviewed-on: http://openocd.zylin.com/4995 Tested-by: jenkins Reviewed-by:
Freddie Chopin <freddie.chopin@gmail.com>
-
Marek Vasut authored
These macros are missing parenthesis around the argument, which can lead to side effects, add them. Replace the argument name to avoid conflict with uint32_t data type, since the macro can be applied to other data types as well. Change-Id: I32d2ffec6c062795d7c8bb23d1dfa3378bfc3a58 Signed-off-by:
Marek Vasut <marek.vasut@gmail.com> Reviewed-on: http://openocd.zylin.com/4994 Tested-by: jenkins Reviewed-by:
Freddie Chopin <freddie.chopin@gmail.com>
-
- 14 Mar, 2019 6 commits
-
-
Marc Schink authored
Change-Id: Ifb114bfc062ed7c0ff6e4f37a1a6d546f5415344 Signed-off-by:
Marc Schink <openocd-dev@marcschink.de> Reviewed-on: http://openocd.zylin.com/4970 Tested-by: jenkins Reviewed-by:
Antonio Borneo <borneo.antonio@gmail.com>
-
Marc Schink authored
Change-Id: I4e117f4e6c8c0850f565587f68f41d88da0d6b0b Signed-off-by:
Marc Schink <openocd-dev@marcschink.de> Reviewed-on: http://openocd.zylin.com/4968 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz> Reviewed-by:
Antonio Borneo <borneo.antonio@gmail.com>
-
Marc Schink authored
Change-Id: Ie7ee82bf04c76ef899ae8b19105158e71b69ae2c Signed-off-by:
Marc Schink <openocd-dev@marcschink.de> Reviewed-on: http://openocd.zylin.com/4962 Tested-by: jenkins Reviewed-by:
Antonio Borneo <borneo.antonio@gmail.com>
-
Christopher Head authored
Bit 4 in OPTSR is IWDG1_SW (the code originally called it IWDG1_HW, but the reference manual refers to it as IWDG1_SW). This is broken out into a separate variable, independent_watchdog_selection, in stm32x_options. However, this is not necessary: bit 4 is included in the user_options field, which includes all of bits 2 through 7, and independent_watchdog_selection is not referenced anywhere else. Delete the field and just rely on user_options to transport that bit, along with all the other bits it contains, between stm32x_read_options and stm32x_write_options. Change-Id: I4da63df9272cf091267b956c412b95671ea1d3c9 Signed-off-by:
Christopher Head <chead@zaber.com> Reviewed-on: http://openocd.zylin.com/4744 Tested-by: jenkins Reviewed-by:
Tarek BOCHKATI <tarek.bouchkati@gmail.com> Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Antonio Borneo authored
Write to register DP_SELECT can fail, but both functions swd_queue_dp_bankselect() and swd_queue_ap_bankselect() return void and do not propagate the error. Change the return type of the two functions to int and check the returned value. Invalidate the cached value of DP_SELECT if the write fails. Change-Id: Iba6ef8b0c2332e7f7efb66337d558fb7a4a0d39c Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/4980 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Antonio Borneo authored
When the register DP_SELECT is written directly, e.g. with command <dap> dpreg 8 <value> the cached value in OpenOCD is not completely updated with the new value, thus creating issues in the following AP and DP read/write that rely on the cached value. Update the cached value while writing to DP_SELECT. Change-Id: I8221b10cd6fc1fbe73e6b834b68820b43480e1a2 Signed-off-by:
Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/4979 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
- 12 Mar, 2019 2 commits
-
-
Tomas Vanek authored
While on it add two missing new lines. Change-Id: I0d54740479bc462b734f91686f0931824796b598 Signed-off-by:
Tomas Vanek <vanekt@fbl.cz> Reviewed-on: http://openocd.zylin.com/4888 Tested-by: jenkins Reviewed-by:
Marc Schink <openocd-dev@marcschink.de>
-
Tomas Vanek authored
instead of conditional compilation #if BUILD_TARGET64 Change-Id: I005ae0b3a4ed127c0f59219b1c6b185a2c76c76e Signed-off-by:
Tomas Vanek <vanekt@fbl.cz> Reviewed-on: http://openocd.zylin.com/4977 Tested-by: jenkins Reviewed-by:
Tim Newsome <tim@sifive.com>
-
- 08 Mar, 2019 2 commits
-
-
Tim Newsome authored
This should allow users to configure flash at >32-bit addresses. Change-Id: I7c9d3c5762579011a2d9708e5317e5765349845c Signed-off-by:
Tim Newsome <tim@sifive.com> Reviewed-on: http://openocd.zylin.com/4919 Tested-by: jenkins Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-
Tim Newsome authored
Targets can use this to expose how many address bits there are. gdb_server uses this to send gdb the appropriate upper limit in the memory-map. (Before this change the upper limit would only be correct for 32-bit targets.) Change-Id: Idb0933255ed53951fcfb05e040674bcdf19441e1 Signed-off-by:
Tim Newsome <tim@sifive.com> Reviewed-on: http://openocd.zylin.com/4947 Tested-by: jenkins Reviewed-by:
Peter Mamonov <pmamonov@gmail.com> Reviewed-by:
Tomas Vanek <vanekt@fbl.cz>
-