Commit f370d706 authored by oharboe's avatar oharboe
Browse files

Duane Ellis: fix warnings

git-svn-id: svn://svn.berlios.de/openocd/trunk@890 b42882b7-edfa-0310-969c-e2dbd0fdcd60
parent 20f505f6
......@@ -27,6 +27,12 @@ is_cygwin=no
is_mingw=no
is_win32=no
AC_ARG_ENABLE(gccwarnings,
AS_HELP_STRING([--enable-gccwarnings], [Enable compiler warnings, default yes]),
[gcc_warnings=$enablevalue], [gcc_warnings=yes])
AC_ARG_ENABLE(parport,
AS_HELP_STRING([--enable-parport], [Enable building the pc parallel port driver]),
[build_parport=$enableval], [build_parport=no])
......@@ -298,11 +304,17 @@ if test $cross_compiling = yes; then
CFLAGS_FOR_BUILD="-g -O2"
else
CC_FOR_BUILD=$CC
CFLAGS_FOR_BUILD=$CFLAGS
CFLAGS_FOR_BUILD="$CFLAGS $GCC_WARNINGS"
fi
if test $gcc_warnings = yes; then
CFLAGS_FOR_BUILD="$CFLAGS_FOR_BUILD -Wall -Wmissing-prototypes -Wstrict-prototypes"
fi
AC_MSG_RESULT([$CC_FOR_BUILD])
AC_SUBST(CC_FOR_BUILD)
AC_SUBST(CFLAGS_FOR_BUILD)
AC_MSG_NOTICE([CFLAGS_FOR_BUILD = $CFLAGS_FOR_BUILD])
AC_MSG_CHECKING([for suffix of executable build tools])
if test $cross_compiling = yes; then
......
......@@ -233,7 +233,7 @@ flash_bank_t *get_flash_bank_by_num_noprobe(int num)
return NULL;
}
int flash_get_bank_count()
int flash_get_bank_count(void)
{
flash_bank_t *p;
int i = 0;
......
......@@ -80,7 +80,7 @@ extern int flash_init_drivers(struct command_context_s *cmd_ctx);
extern int flash_erase_address_range(target_t *target, u32 addr, u32 length);
extern int flash_write(target_t *target, image_t *image, u32 *written, int erase);
extern void flash_set_dirty(void);
extern int flash_get_bank_count();
extern int flash_get_bank_count(void);
extern int default_flash_blank_check(struct flash_bank_s *bank);
extern int default_flash_mem_blank_check(struct flash_bank_s *bank);
......
......@@ -71,7 +71,7 @@ extern int unregister_all_commands(command_context_t *context);
extern void command_set_output_handler(command_context_t* context, int (*output_handler)(struct command_context_s *context, const char* line), void *priv);
extern command_context_t* copy_command_context(command_context_t* context);
extern int command_context_mode(command_context_t *context, enum command_mode mode);
extern command_context_t* command_init();
extern command_context_t* command_init(void);
extern int command_done(command_context_t *context);
extern void command_print(command_context_t *context, char *format, ...);
extern void command_print_sameline(command_context_t *context, char *format, ...);
......
......@@ -59,8 +59,8 @@ __attribute__ ((format (printf, 5, 6)));
extern int log_register_commands(struct command_context_s *cmd_ctx);
extern int log_init(struct command_context_s *cmd_ctx);
extern int set_log_output(struct command_context_s *cmd_ctx, FILE *output);
extern void keep_alive();
extern void kept_alive();
extern void keep_alive(void);
extern void kept_alive(void);
typedef void (*log_callback_fn)(void *priv, const char *file, int line,
const char *function, const char *string);
......
......@@ -38,7 +38,7 @@ extern int timeval_subtract(struct timeval *result, struct timeval *x, struct ti
extern int timeval_add(struct timeval *result, struct timeval *x, struct timeval *y);
extern int timeval_add_time(struct timeval *result, int sec, int usec);
/* gettimeofday() timeval in 64 bit ms */
extern long long timeval_ms();
extern long long timeval_ms(void);
typedef struct duration_s
{
......
......@@ -166,7 +166,7 @@ void amt_jtagaccel_end_state(state)
}
}
void amt_wait_scan_busy()
void amt_wait_scan_busy(void)
{
int timeout = 4096;
u8 ar_status;
......
......@@ -194,7 +194,7 @@ int gw16012_speed(int speed)
return ERROR_OK;
}
void gw16012_end_state(state)
void gw16012_end_state(int state)
{
if (tap_move_map[state] != -1)
end_state = state;
......@@ -526,7 +526,7 @@ int gw16012_init(void)
LOG_WARNING("No gw16012 port specified, using default '0x378' (LPT1)");
}
LOG_DEBUG("requesting privileges for parallel port 0x%lx...", gw16012_port);
LOG_DEBUG("requesting privileges for parallel port 0x%lx...", (long unsigned)(gw16012_port) );
#if PARPORT_USE_GIVEIO == 1
if (gw16012_get_giveio_access() != 0)
#else /* PARPORT_USE_GIVEIO */
......
......@@ -401,7 +401,7 @@ void* cmd_queue_alloc(size_t size)
return t + offset;
}
void cmd_queue_free()
void cmd_queue_free(void)
{
cmd_queue_page_t *page = cmd_queue_pages;
......@@ -416,7 +416,7 @@ void cmd_queue_free()
cmd_queue_pages = NULL;
}
static void jtag_prelude1()
static void jtag_prelude1(void)
{
if (jtag_trst == 1)
{
......@@ -1433,7 +1433,7 @@ int jtag_examine_chain()
return ERROR_OK;
}
int jtag_validate_chain()
int jtag_validate_chain(void)
{
jtag_device_t *device = jtag_devices;
int total_ir_length = 0;
......
......@@ -282,8 +282,8 @@ extern int interface_jtag_add_plain_dr_scan(int num_fields, scan_field_t *fields
/* run a TAP_TLR reset. End state is TAP_TLR, regardless
* of start state.
*/
extern void jtag_add_tlr();
extern int interface_jtag_add_tlr();
extern void jtag_add_tlr(void);
extern int interface_jtag_add_tlr(void);
/* Do not use jtag_add_pathmove() unless you need to, but do use it
* if you have to.
*
......
......@@ -21,11 +21,11 @@
/* implementations of OpenOCD that uses multithreading needs to know when
* OpenOCD is sleeping. No-op in vanilla OpenOCD
*/
void openocd_sleep_prelude()
void openocd_sleep_prelude(void)
{
}
void openocd_sleep_postlude()
void openocd_sleep_postlude(void)
{
}
......
......@@ -2002,7 +2002,7 @@ int gdb_input(connection_t *connection)
return ERROR_OK;
}
int gdb_init()
int gdb_init(void)
{
gdb_service_t *gdb_service;
target_t *target = targets;
......
......@@ -46,7 +46,7 @@ typedef struct gdb_service_s
struct target_s *target;
} gdb_service_t;
extern int gdb_init();
extern int gdb_init(void);
extern int gdb_register_commands(command_context_t *command_context);
#define ERROR_GDB_BUFFER_TOO_SMALL (-800)
......
......@@ -222,7 +222,7 @@ int remove_service(unsigned short port)
return ERROR_OK;
}
int remove_services()
int remove_services(void)
{
service_t *c = services;
......@@ -249,8 +249,8 @@ int remove_services()
return ERROR_OK;
}
extern void openocd_sleep_prelude();
extern void openocd_sleep_postlude();
extern void openocd_sleep_prelude(void);
extern void openocd_sleep_postlude(void);
int server_loop(command_context_t *command_context)
{
......@@ -434,7 +434,7 @@ void sig_handler(int sig) {
}
#endif
int server_init()
int server_init(void)
{
#ifdef _WIN32
WORD wVersionRequested;
......@@ -460,7 +460,7 @@ int server_init()
return ERROR_OK;
}
int server_quit()
int server_quit(void)
{
remove_services();
......
......@@ -68,8 +68,8 @@ typedef struct service_s
} service_t;
extern int add_service(char *name, enum connection_type type, unsigned short port, int max_connections, new_connection_handler_t new_connection_handler, input_handler_t input_handler, connection_closed_handler_t connection_closed_handler, void *priv);
extern int server_init();
extern int server_quit();
extern int server_init(void);
extern int server_quit(void);
extern int server_loop(command_context_t *command_context);
extern int server_register_commands(command_context_t *context);
......
......@@ -1716,7 +1716,7 @@ int arm11_handle_mrc_mcr(struct command_context_s *cmd_ctx, char *cmd, char **ar
if (values[i] > arm11_coproc_instruction_limits[i])
{
LOG_ERROR("Parameter %ld out of bounds (%d max). %s",
i + 2, arm11_coproc_instruction_limits[i],
(long)(i + 2), arm11_coproc_instruction_limits[i],
read ? arm11_mrc_syntax : arm11_mcr_syntax);
return -1;
}
......
......@@ -43,7 +43,7 @@ int arm720t_handle_mw_phys_command(struct command_context_s *cmd_ctx, char *cmd,
/* forward declarations */
int arm720t_target_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, struct target_s *target);
int arm720t_init_target(struct command_context_s *cmd_ctx, struct target_s *target);
int arm720t_quit();
int arm720t_quit(void);
int arm720t_arch_state(struct target_s *target);
int arm720t_read_memory(struct target_s *target, u32 address, u32 size, u32 count, u8 *buffer);
int arm720t_write_memory(struct target_s *target, u32 address, u32 size, u32 count, u8 *buffer);
......@@ -423,7 +423,7 @@ int arm720t_init_target(struct command_context_s *cmd_ctx, struct target_s *targ
}
int arm720t_quit()
int arm720t_quit(void)
{
return ERROR_OK;
......
......@@ -46,7 +46,7 @@ int arm7tdmi_register_commands(struct command_context_s *cmd_ctx);
/* forward declarations */
int arm7tdmi_target_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, struct target_s *target);
int arm7tdmi_init_target(struct command_context_s *cmd_ctx, struct target_s *target);
int arm7tdmi_quit();
int arm7tdmi_quit(void);
/* target function declarations */
int arm7tdmi_poll(struct target_s *target);
......@@ -753,7 +753,7 @@ int arm7tdmi_init_target(struct command_context_s *cmd_ctx, struct target_s *tar
}
int arm7tdmi_quit()
int arm7tdmi_quit(void)
{
return ERROR_OK;
......
......@@ -48,7 +48,7 @@ int arm920t_handle_read_mmu_command(struct command_context_s *cmd_ctx, char *cmd
/* forward declarations */
int arm920t_target_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, struct target_s *target);
int arm920t_init_target(struct command_context_s *cmd_ctx, struct target_s *target);
int arm920t_quit();
int arm920t_quit(void);
int arm920t_arch_state(struct target_s *target);
int arm920t_read_memory(struct target_s *target, u32 address, u32 size, u32 count, u8 *buffer);
int arm920t_write_memory(struct target_s *target, u32 address, u32 size, u32 count, u8 *buffer);
......@@ -685,7 +685,7 @@ int arm920t_init_target(struct command_context_s *cmd_ctx, struct target_s *targ
}
int arm920t_quit()
int arm920t_quit(void)
{
return ERROR_OK;
......
......@@ -48,7 +48,7 @@ int arm926ejs_handle_read_mmu_command(struct command_context_s *cmd_ctx, char *c
/* forward declarations */
int arm926ejs_target_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, struct target_s *target);
int arm926ejs_init_target(struct command_context_s *cmd_ctx, struct target_s *target);
int arm926ejs_quit();
int arm926ejs_quit(void);
int arm926ejs_arch_state(struct target_s *target);
int arm926ejs_read_memory(struct target_s *target, u32 address, u32 size, u32 count, u8 *buffer);
int arm926ejs_write_memory(struct target_s *target, u32 address, u32 size, u32 count, u8 *buffer);
......@@ -666,7 +666,7 @@ int arm926ejs_init_target(struct command_context_s *cmd_ctx, struct target_s *ta
}
int arm926ejs_quit()
int arm926ejs_quit(void)
{
return ERROR_OK;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment