Commit 2b66816a authored by Marek Vasut's avatar Marek Vasut Committed by Freddie Chopin
Browse files

mips32: pracc: Fix UPPER/LOWER macros

These macros are missing parenthesis around the argument, which can
lead to side effects, add them. Replace the argument name to avoid
conflict with uint32_t data type, since the macro can be applied to
other data types as well.

Change-Id: I32d2ffec6c062795d7c8bb23d1dfa3378bfc3a58
Signed-off-by: default avatarMarek Vasut <>

Tested-by: jenkins
Reviewed-by: default avatarFreddie Chopin <>
parent 8f518d35
......@@ -39,8 +39,8 @@
#define UPPER16(uint32_t) (uint32_t >> 16)
#define LOWER16(uint32_t) (uint32_t & 0xFFFF)
#define UPPER16(addr) ((addr) >> 16)
#define LOWER16(addr) ((addr) & 0xFFFF)
#define NEG16(v) (((~(v)) + 1) & 0xFFFF)
#define SWAP16(v) ((LOWER16(v) << 16) | (UPPER16(v)))
/*#define NEG18(v) (((~(v)) + 1) & 0x3FFFF)*/
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment