Skip to content
  • Zachary T Welch's avatar
    improve command_done() API and docs · bc9ae740
    Zachary T Welch authored
    command_done() does not need to return an error, but it needed
    Doxygen comment.  Provide some for copy_command_context as well.
    
    Note: this audit revealed some potential bugs with the command context
    implementation.  There was a reason that commands were added at the
    end of the list.  Shallow copying of command_context means that
    the list is shared between them.  And commands added at the top-level
    before the pre-existing commands will not be available in the shared
    context as they were before.  Yikes!
    
    Fortunately, this does not seem to occur in general use, as
    'add_help_text' gets registered in startup.tcl and claims the first slot
    in my own test cases.  Thus, it seems that we have been masking the issue
    for now, but it shows the need for further architectural improvement in
    the core command module.
    bc9ae740