Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • F firmware
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 74
    • Issues 74
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • card10card10
  • firmware
  • Merge requests
  • !332

Ofscreen lines

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Stewart requested to merge sodoku/firmware:ofscreen_lines into master Oct 05, 2019
  • Overview 4
  • Commits 5
  • Pipelines 3
  • Changes 6

The animation of the simple_menu used in the main menu had the issue that there is a black line visible at the top. This is due the gfx_puts method ignoring lines, where the top pixel of the string is above the top of the screen. As gfx_puts uses gfx_setpixel which in turn ignores pixels outside of the screen, I removed the check in gfx_puts.

I also removed the ranges from the documentation of the individual python functions and added a general documentation about the screen and it's ranges.

Related: #178

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ofscreen_lines