Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • F firmware
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 74
    • Issues 74
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • card10card10
  • firmware
  • Merge requests
  • !328

fix(build): Fix module changes not getting picked up

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged rahix requested to merge rahix/meson-micropython into master Oct 04, 2019
  • Overview 1
  • Commits 1
  • Pipelines 3
  • Changes 4

Previously, we left out the dependency of the QSTR header on modules.h. This was done to prevent rebuilds of the entire MicroPython sources whenever a Pycardium module is changed. This leads to issues where QSTRs got out of sync and weird errors like the following could happen:

import foo_module

Exception: No module `abc_def` (a different string than expected)

Attempt to fix this by only updating the QSTR header when the module-header actually changes. For this, a few workarounds are needed:

  • Replace symlinks with actual copied files so timestamps change on updates.
  • Add a hack so meson picks up on the dependency of the file in genhdr/

Co-authored-by: dx dequis@dequis.org


@schneider: Please test whether this works on your system as well ;)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rahix/meson-micropython