Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • F firmware
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 74
    • Issues 74
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • card10card10
  • firmware
  • Merge requests
  • !323

Fix only configuring portexpander with MXC_ASSERT enabled

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rahix requested to merge rahix/fix-portexpander-init into master Oct 03, 2019
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

When MXC_ASSERT is disabled, the portexpander_config() call is not compiled into the bootloader which leads to the portexpander not being setup correctly and thus neither the screen turns on nor does the button to switch into MSC mode work correctly (bootloader always goes into MSC mode).

Fix this by moving the portexpander_config() call outside the MXC_ASSERT and only keep the return value check inside. Additionally fix the pull-up/pull-down selection in portexpander_config() not being set correctly.

Fixes #171 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rahix/fix-portexpander-init